Skip to content

Expose tools and instructions in the Dev Server payload#6772

Merged
vividviolet merged 1 commit intomainfrom
01-16-expose_tools_and_instructions_in_the_dev_server_payload
Jan 21, 2026
Merged

Expose tools and instructions in the Dev Server payload#6772
vividviolet merged 1 commit intomainfrom
01-16-expose_tools_and_instructions_in_the_dev_server_payload

Conversation

@vividviolet
Copy link
Member

@vividviolet vividviolet commented Jan 16, 2026 •
edited
Loading

WHY are these changes introduced?

Related to https://github.com/shop/issues-admin-extensibility/issues/2127

WHAT is this pull request doing?

  • Introduces a new BuildAsset interface to standardize asset definitions
  • Refactors the extension point asset handling with a more modular approach using asset mappers
  • Adds support for tools and instructions assets in the build manifest
  • Improves the payload generation for UI extensions with a more structured approach
  • Adds tests for the new asset types (tools and instructions)

How to test your changes?

  1. Follow the instructions in this PR but running the CLI from this branch instead
  2. Run dev and open the Dev Console
  3. Open the Chrome Network inspector and verify that assets.tools and assets.instructions are present in the extension point's payload
  4. Make some changes to tools and instruction files and verify that the lastUpdate timestamp is updated

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@vividviolet Graphite App
Copy link
Member Author

vividviolet commented Jan 16, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vividviolet vividviolet force-pushed the 01-16-expose_tools_and_instructions_in_the_dev_server_payload branch from 549c242 to 0108275 Compare January 16, 2026 19:24
@vividviolet vividviolet mentioned this pull request Jan 16, 2026
Draft
5 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
79.53% (+0.3% 🔼)
 14346/18038
🟡 Branches
73.8% (+0.69% 🔼)
 7083/9598
🟡 Functions
79.66% (+0.29% 🔼)
 3669/4606
🟡 Lines
79.9% (+0.31% 🔼)
 13563/16976
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / admin-as-app.ts
 100% 100% 100% 100%
🟢
... / metafield_definitions.ts
 100% 100% 100% 100%
🟢
... / metaobject_definitions.ts
 100% 100% 100% 100%
🟢
... / bulk-operation-cancel.ts
 100% 100% 100% 100%
🟢
... / bulk-operation-run-mutation.ts
 100% 100% 100% 100%
🟢
... / bulk-operation-run-query.ts
 100% 100% 100% 100%
🟢
... / get-bulk-operation-by-id.ts
 100% 100% 100% 100%
🟢
... / list-bulk-operations.ts
 100% 100% 100% 100%
🟢
... / staged-uploads-create.ts
 100% 100% 100% 100%
🟢
... / fetch_store_by_domain.ts
 100% 100% 100% 100%
🔴
... / import-custom-data-definitions.ts
 0% 100% 0% 0%
🔴
... / cancel.ts
 0% 100% 0% 0%
🔴
... / execute.ts
 0% 0% 0% 0%
🔴
... / status.ts
 0% 0% 0% 0%
🔴
... / pull.ts
 0% 100% 0% 0%
🟡
... / execute-operation.ts
 75% 50% 100% 75%
🔴
... / pull.ts
 0% 0% 0% 0%
🟢
... / bulk-operation-status.ts
 96.55% 92.11% 100% 100%
🟢
... / cancel-bulk-operation.ts
 100% 100% 100% 100%
🟢
... / constants.ts
 100% 100% 100% 100%
🟢
... / download-bulk-operation-results.ts
 100% 100% 100% 100%
🟢
... / execute-bulk-operation.ts
 92.06% 86.05% 100% 93.55%
🟢
... / format-bulk-operation-status.ts
 100% 100% 100% 100%
🟢
... / run-mutation.ts
 100% 100% 100% 100%
🟢
... / run-query.ts
 100% 100% 100% 100%
🟡
... / stage-file.ts
 73.53% 62.5% 85.71% 72.73%
🟢
... / watch-bulk-operation.ts
 100% 94.74% 100% 100%
🟢
... / declarative-definitions.ts
 98.54% 93.18% 100% 98.51%
🟢
... / common.ts
 97.62% 95% 100% 97.06%
🟢
... / execute-command-helpers.ts
 100% 100% 100% 100%
🟢
... / file-formatter.ts
 100% 100% 100% 100%
🔴
... / promiseWithResolvers.ts
 33.33% 50% 50% 33.33%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / execute.ts
 0%
0% (-100% 🔻)
 0% 0%
🟢
... / loader.ts
94.06% (+0.2% 🔼)
86.41% (-0.42% 🔻)
97.17% (+0.11% 🔼)
94.85% (+0.18% 🔼)
🟢
... / extension-instance.ts
84.8% (+0.23% 🔼)
77.6% (-0.91% 🔻)
92.06% (+0.13% 🔼)
85.11% (+0.24% 🔼)
🟡
... / specification.ts
69.64% (+0.55% 🔼)
75.61% (+2.44% 🔼)
76.47% (-1.31% 🔻)
69.39% (+0.64% 🔼)
🟢
... / ui_extension.ts
88.61% (-6.22% 🔻)
78.57% (-2.68% 🔻)
85.19% (-14.81% 🔻)
90.79% (-5.67% 🔻)
🟢
... / store-context.ts
 100%
82.35% (-0.98% 🔻)
 100% 100%
🟢
... / Logs.tsx
 90%
90.91% (-5.97% 🔻)
 100% 90%
🟢
... / fetch.ts
84.21% (+0.88% 🔼)
82.35% (-0.98% 🔻)
 75%
85.29% (+1.42% 🔼)
🟢
... / app-event-watcher-handler.ts
86.36% (-4.11% 🔻)
 75% 86.67%
85.71% (-5.19% 🔻)
🟢
... / bundle.ts
 93.22%
63.33% (-3.33% 🔻)
94.12% (+5.88% 🔼)
 96.3%
🟢
... / developer-platform-client.ts
84.62% (-1.5% 🔻)
71.43% (+0.84% 🔼)
81.82% (+1.82% 🔼)
93.75% (+0.42% 🔼)
🔴
... / http-reverse-proxy.ts
58.97% (-4.91% 🔻)
37.04% (-2.96% 🔻)
58.33% (-5.3% 🔻)
59.46% (-5.25% 🔻)
🔴
... / app-management-client.ts
53.69% (-0.16% 🔻)
 47.47%
50% (-0.45% 🔻)
52.53% (-0.17% 🔻)
🟢
... / api.ts
87.07% (-0.43% 🔻)
76.71% (-0.1% 🔻)
 100%
86.49% (-0.43% 🔻)
🟢
... / SingleTask.tsx
84.21% (-15.79% 🔻)
50% (-50% 🔻)
80% (-20% 🔻)
84.21% (-15.79% 🔻)
🔴
... / environment.ts
35% (-5% 🔻)
 41.18%
40% (-10% 🔻)
36.84% (-5.26% 🔻)
🔴
... / ui.tsx
50.82% (-0.79% 🔻)
42.86% (-5.53% 🔻)
54.55% (+1.42% 🔼)
50% (-0.82% 🔻)
🟢
... / console.ts
81.82% (+15.15% 🔼)
75% (-25% 🔻)
100% (+33.33% 🔼)
81.82% (+15.15% 🔼)
🟢
... / init.ts
88% (-0.89% 🔻)
71.43% (+4.76% 🔼)
86.67% (+4.85% 🔼)
88% (-0.89% 🔻)
🟢
... / storefront-renderer.ts
90.2% (-0.54% 🔻)
 78.95%
81.82% (-1.52% 🔻)
90.2% (-0.54% 🔻)
🟡
... / theme-polling.ts
67.12% (-0.93% 🔻)
 68.75% 78.57%
66.67% (-0.98% 🔻)

Test suite run success

3658 tests passing in 1428 suites.

Report generated by 🧪jest coverage report action from 6ca4e28

@vividviolet vividviolet force-pushed the 01-16-expose_tools_and_instructions_in_the_dev_server_payload branch 3 times, most recently from 3e48836 to b7a1159 Compare January 16, 2026 20:13
@vividviolet vividviolet marked this pull request as ready for review January 20, 2026 04:30
@vividviolet vividviolet requested a review from a team as a code owner January 20, 2026 04:30
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@vividviolet vividviolet force-pushed the 01-16-expose_tools_and_instructions_in_the_dev_server_payload branch from b7a1159 to 0a197cc Compare January 20, 2026 04:31
olavoasantos
olavoasantos reviewed Jan 20, 2026
View reviewed changes
@vividviolet vividviolet force-pushed the 01-16-expose_tools_and_instructions_in_the_dev_server_payload branch from 0a197cc to 6ca4e28 Compare January 20, 2026 21:19
@vividviolet vividviolet added this pull request to the merge queue Jan 21, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2026
@vividviolet vividviolet added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main with commit 84c4102 Jan 21, 2026
25 checks passed
@vividviolet vividviolet deleted the 01-16-expose_tools_and_instructions_in_the_dev_server_payload branch January 21, 2026 22:06
@vividviolet vividviolet added the #gsd:49116 Sidekick app extensions: app data label Jan 30, 2026 — with Graphite App
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmerand dmerand dmerand approved these changes

@olavoasantos olavoasantos olavoasantos approved these changes

Assignees

No one assigned

Labels

#gsd:49116 Sidekick app extensions: app data

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vividviolet @dmerand @olavoasantos